On Mon, Jul 31, 2017 at 08:19:32PM +0000, Kani, Toshimitsu wrote: > I'd prefer to add the whitelist check to ghes_edac first. This makes > the existing code to work. We can then work on refactoring changes > like this on top of it without breaking the functionality.
Yes, but we want only the whitelist - not the FF testing because, as we said, BIOS is notoriously buggy so we're going to load ghes_edac only on known-good platforms. Which brings the question about the priority. And I *think* the easiest would be if the whitelist were in the core edac.ko module, perhaps in edac_module.c (even though it doesn't really matter, technically). There we can set a "use_ghes" or so bool which the x86 platform drivers would query through accessor functions and determine whether to load or not. In any case, something like that. I'm always open for better suggestions, though. I've pushed a rebased branch here: https://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git/log/?h=ghes feel free to base your changes ontop. Thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --
