On Wed, 2 Aug 2017 14:40:06 +0530, Bhumika Goyal wrote:
> Add const to bin_attribute structures as they are only passed to the
> functions sysfs_{remove/create}_bin_file. The arguments passed are of
> type const, so declare the structures to be const.
>
> Done using Coccinelle.
>
> @m disable optional_qualifier@
> identifier s;
> position p;
> @@
> static struct bin_attribute s@p={...};
>
> @okay1@
> position p;
> identifier m.s;
> @@
> (
> sysfs_create_bin_file(...,&s@p,...)
> |
> sysfs_remove_bin_file(...,&s@p,...)
> )
>
> @bad@
> position p!={m.p,okay1.p};
> identifier m.s;
> @@
> s@p
>
> @change depends on !bad disable optional_qualifier@
> identifier m.s;
> @@
> static
> +const
> struct bin_attribute s={...};
>
> Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
> ---
> drivers/misc/ds1682.c | 2 +-
> drivers/misc/eeprom/eeprom.c | 2 +-
> drivers/misc/eeprom/max6875.c | 2 +-
> drivers/misc/pch_phub.c | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
> (...)
Reviewed-by: Jean Delvare <jdelv...@suse.de>
Thanks,
--
Jean Delvare
SUSE L3 Support
