> > +       chip->enable_gpio = devm_gpiod_get(&spi->dev, "enable",
> GPIOD_OUT_LOW);
> > +       if (IS_ERR(chip->enable_gpio)) {
> > +               dev_dbg(&spi->dev, "No enable-gpios property\n");
> > +               chip->enable_gpio = NULL;
> 
> Also, the error handling here is not correct as it will never propagate
> EPROBE_DEFER.
> 
> I will submit my version of the patch if you don't mind.

That's ok if you have a better patch.

Regards,
Peng.

Reply via email to