Parag Warudkar napsal(a): > On Mon, 23 Apr 2007, Jiri Kosina wrote: > >> On Sun, 22 Apr 2007, Parag Warudkar wrote: >> >>> @@ -1097,8 +1097,13 @@ >>> >>> /* Driver specific per-device data */ >>> chip = kzalloc(sizeof(*chip), GFP_KERNEL); >>> - if (chip == NULL) >>> + devname = kmalloc(DEVNAME_SIZE, GFP_KERNEL); >>> + + if (chip == NULL || devname == NULL) { >> >> Hi, >> >> this line looks bogus to me. >> > > Hi - Yep, thanks for catching. Really not sure how that extra + got in > there - I diffed the exact same file this morning and it isn't there - > new diff attached. [...] > @@ -1097,8 +1097,13 @@ > > /* Driver specific per-device data */ > chip = kzalloc(sizeof(*chip), GFP_KERNEL); > - if (chip == NULL) > + devname = kmalloc(DEVNAME_SIZE, GFP_KERNEL); > + + if (chip == NULL || devname == NULL) {
I see this here too, but there is no extra '+' here: http://lkml.org/lkml/2007/4/22/172 and here http://lkml.org/lkml/2007/4/23/125 not even in the source of this message, weird... (using thunderbird 2.0rc1) regards, -- http://www.fi.muni.cz/~xslaby/ Jiri Slaby faculty of informatics, masaryk university, brno, cz e-mail: jirislaby gmail com, gpg pubkey fingerprint: B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/