On Fri, Aug 4, 2017 at 10:19 PM, Nick Terrell <terre...@fb.com> wrote: > --- a/fs/squashfs/decompressor.c > +++ b/fs/squashfs/decompressor.c > @@ -65,6 +65,12 @@ static const struct squashfs_decompressor > squashfs_zlib_comp_ops = { > }; > #endif > > +#ifndef CONFIG_SQUASHFS_ZSTD > +static const struct squashfs_decompressor squashfs_zstd_comp_ops = { > + NULL, NULL, NULL, NULL, ZSTD_COMPRESSION, "zstd", 0
Can you please use designated initializers? > +}; > +#endif > + > static const struct squashfs_decompressor squashfs_unknown_comp_ops = { > NULL, NULL, NULL, NULL, 0, "unknown", 0 > ; > +const struct squashfs_decompressor squashfs_zstd_comp_ops = { > + .init = zstd_init, > + .free = zstd_free, > + .decompress = zstd_uncompress, > + .id = ZSTD_COMPRESSION, > + .name = "zstd", > + .supported = 1 > +}; ... like you did here. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds