On Mon 14-08-17 09:39:17, Pasha Tatashin wrote: > >>#ifdef CONFIG_MEMBLOCK in page_alloc, or define memblock_discard() stubs in > >>nobootmem headfile. > > > >This is the standard way to do this. And it is usually preferred to > >proliferate ifdefs in the code. > > Hi Michal, > > As you suggested, I sent-out this patch separately. If you feel strongly, > that this should be updated to have stubs for platforms that do not > implement memblock, please send a reply to that e-mail, so those who do not > follow this tread will see it. Otherwise, I can leave it as is, page_alloc > file already has a number memblock related ifdefs all of which can be > cleaned out once every platform implements it (is it even achievable?)
I do not think this needs a repost just for this. This was merely a JFYI, in case you would need to repost for other reasons then just update that as well. But nothing really earth shattering. -- Michal Hocko SUSE Labs
