On (24/04/07 18:58), Yasunori Goto didst pronounce: > > > > Subject: Check zone boundaries when freeing bootmem > > Zone boundaries do not have to be aligned to MAX_ORDER_NR_PAGES. > > Hmm. I don't understand here yet... Could you explain more? > > This issue occurs only when ZONE_MOVABLE is specified. > If its boundary is aligned to MAX_ORDER automatically, > I guess user will not mind it. > > From memory hotplug view, I prefer section size alignment to make > simple code. :-P How does this look to you?
====== The two potential users of ZONE_MOVABLE would prefer if the zone was aligned to a boundary. This patch aligns the zone to a MAX_ORDER_NR_PAGES boundary. Signed-off-by: Mel Gorman <[EMAIL PROTECTED]> diff -rup -X /usr/src/patchset-0.6/bin//dontdiff linux-2.6.21-rc6-mm1-002_commonparse/mm/page_alloc.c linux-2.6.21-rc6-mm1-003_alignmovable/mm/page_alloc.c --- linux-2.6.21-rc6-mm1-002_commonparse/mm/page_alloc.c 2007-04-24 09:38:30.000000000 +0100 +++ linux-2.6.21-rc6-mm1-003_alignmovable/mm/page_alloc.c 2007-04-24 11:15:40.000000000 +0100 @@ -3642,6 +3642,11 @@ restart: usable_nodes--; if (usable_nodes && required_kernelcore > usable_nodes) goto restart; + + /* Align start of ZONE_MOVABLE on all nids to MAX_ORDER_NR_PAGES */ + for (nid = 0; nid < MAX_NUMNODES; nid++) + zone_movable_pfn[nid] = + roundup(zone_movable_pfn[nid], MAX_ORDER_NR_PAGES); } /** -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/