From: Randy Dunlap <rdun...@infradead.org> Date: Tue, 15 Aug 2017 09:41:53 -0700
> On 08/15/2017 06:51 AM, Neal Cardwell wrote: >> On Tue, Aug 15, 2017 at 9:08 AM, mohamedalrshah >> <mohamed.a.alrs...@ieee.org> wrote: >> >>> +static void agilesdtcp_cong_avoid(struct sock *sk, u32 ack, u32 in_flight) >>> +{ >>> + struct tcp_sock *tp = tcp_sk(sk); >>> + struct agilesdtcp *ca = inet_csk_ca(sk); >>> + u32 inc_factor; >>> + u32 ca_inc; >>> + u32 current_gap, total_gap; >> >> For coding style, please order local variable declarations from >> longest to shortest line, also know as Reverse Christmas Tree Format. > > Per what coding style, please? This is not in current coding style nor in the > netdev-FAQ exceptions. It is the established practice, documented or not, and I enforce this for all networking code submissions.