There is a mistake here where we accidentally use sizeof(TB_CFG_PKG_RESET)
instead of just TB_CFG_PKG_RESET.  The size of an int is 4 so it's the
same as TB_CFG_PKG_NOTIFY_ACK.

Fixes: d7f781bfdbf4 ("thunderbolt: Rework control channel to be more reliable")
Reported-by: Colin King <colin.k...@canonical.com>
Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>
Acked-by: Mika Westerberg <mika.westerb...@linux.intel.com>
---
Resending with Greg CC'd.  This was also:
Signed-off-by: Andreas Noever <andreas.noe...@gmail.com>
But I wasn't sure if I should add that tag.

diff --git a/drivers/thunderbolt/ctl.c b/drivers/thunderbolt/ctl.c
index 69c0232a22f8..fb40dd0588b9 100644
--- a/drivers/thunderbolt/ctl.c
+++ b/drivers/thunderbolt/ctl.c
@@ -804,7 +804,7 @@ struct tb_cfg_result tb_cfg_reset(struct tb_ctl *ctl, u64 
route,
        req->request_type = TB_CFG_PKG_RESET;
        req->response = &reply;
        req->response_size = sizeof(reply);
-       req->response_type = sizeof(TB_CFG_PKG_RESET);
+       req->response_type = TB_CFG_PKG_RESET;
 
        res = tb_cfg_request_sync(ctl, req, timeout_msec);
 

Reply via email to