On Wed, Aug 16, 2017 at 3:46 PM, Eric W. Biederman <ebied...@xmission.com> wrote: >> tty->link->driver_data = pts_path; >> >> retval = ptm_driver->ops->open(tty, filp); > ^^^^^^^ > > If this open fails the code jumps to err_put_path which falls > through into out_put_fsi.
No it doesn't. err_path_put falls through to err_release, but that then does a "return retval;". It doesn't get to out_put_fsi. Now, I _do_ want people to check the release path, but I don't think this was it. Or am I blind and missing something? Linus