On 18/08/2017 14:36, Radim Krčmář wrote:
>>> + gpa = vcpu->arch.gpa_val;
>>> + ret = vcpu_is_mmio_gpa(vcpu, addr, gpa, write);
>>> + } else {
>>> + ret = vcpu_mmio_gva_to_gpa(vcpu, addr, &gpa, exception, write);
>>> }
>>>
>>> - ret = vcpu_mmio_gva_to_gpa(vcpu, addr, &gpa, exception, write);
>>> -
>>> if (ret < 0)
>>> return X86EMUL_PROPAGATE_FAULT;
>> just wondering if it makes sense to move this into the else branch (as
>> it logically only belongs to vcpu_mmio_gva_to_gpa)
>
> It does, I took the liberty to change that.
It was on purpose, but it's okay either way. :)
Paolo
