On Fri, Aug 11, 2017 at 04:26:16PM -0700, Andi Kleen wrote: > From: Andi Kleen <[email protected]> > > Save the original array dimensions in xyarrays, so that users can retrieve > them > later. Add some inline functions to access these fields. > > Signed-off-by: Andi Kleen <[email protected]> > --- > tools/perf/util/xyarray.c | 2 ++ > tools/perf/util/xyarray.h | 12 ++++++++++++ > 2 files changed, 14 insertions(+) > > diff --git a/tools/perf/util/xyarray.c b/tools/perf/util/xyarray.c > index 7251fdbabced..c8f415d9877b 100644 > --- a/tools/perf/util/xyarray.c > +++ b/tools/perf/util/xyarray.c > @@ -12,6 +12,8 @@ struct xyarray *xyarray__new(int xlen, int ylen, size_t > entry_size) > xy->entry_size = entry_size; > xy->row_size = row_size; > xy->entries = xlen * ylen; > + xy->max_x = xlen; > + xy->max_y = ylen; > } > > return xy; > diff --git a/tools/perf/util/xyarray.h b/tools/perf/util/xyarray.h > index 7f30af371b7e..785884158137 100644 > --- a/tools/perf/util/xyarray.h > +++ b/tools/perf/util/xyarray.h > @@ -7,6 +7,8 @@ struct xyarray { > size_t row_size; > size_t entry_size; > size_t entries; > + size_t max_x; > + size_t max_y; > char contents[]; > }; > > @@ -19,4 +21,14 @@ static inline void *xyarray__entry(struct xyarray *xy, int > x, int y) > return &xy->contents[x * xy->row_size + y * xy->entry_size]; > } > > +static inline int xy_max_y(struct xyarray *xy) > +{ > + return xy->max_x; > +} > + > +static inline int xy_max_x(struct xyarray *xy) > +{ > + return xy->max_y; > +}
I think you should follow the standard naming and use xyarray__max_x and xyarray__max_y jirka
