On Tue, 2017-08-22 at 07:57 +0200, Takashi Iwai wrote:
> This patch adds the opregion driver for Dollar Cove TI PMIC on Intel
> Cherry Trail devices. The patch is based on the original work by
> Intel, found at:
> https://github.com/01org/ProductionKernelQuilts
> with many cleanups and rewrites.
>
> The driver is currently provided only as built-in to follow other
> PMIC opregion drivers convention.
>
> The re-enumeration of devices at probe is required for fixing the
> issues on HP x2 210 G2. See bug#195689.
>
>
> +static int dc_ti_pmic_get_raw_temp(struct regmap *regmap, int reg)
> +{
> + int temp_l, temp_h;
> +
> + if (regmap_read(regmap, reg, &temp_l) ||
> + regmap_read(regmap, reg - 1, &temp_h))
> + return -EIO;
> +
> + return temp_l | (temp_h & 0x3) << 8;
> +}
I'm not sure I understand this "- 1" part along with choice of l and h
suffixes.
Does it mean the register is big endian?
--
Andy Shevchenko <[email protected]>
Intel Finland Oy
