On Tue, 22 Aug 2017 11:42:08 +0200, Andy Shevchenko wrote: > > On Tue, 2017-08-22 at 07:57 +0200, Takashi Iwai wrote: > > This provides a new input driver for supporting the power button on > > Dollar Cove TI PMIC, found on Cherrytrail-based devices. > > The patch is based on the original work by Intel, found at: > > https://github.com/01org/ProductionKernelQuilts > > For now we have similar driver under drivers/platform/x86. > > I think when we move to regmap API there we might even reuse > intel_mid_powerbtn.c.
Ah, OK, that can be a better place. I'll move to there. Also, from comparison with intel_mid_powerbtn.c, I noticed that the irq wake isn't cleared at removal. Will address it as well. > Or other way around, move that one to input subsystem (which I > personally see less fit). I don't think it's worth, either. I updated the patches and now pushed to topic/dollar-cove-ti-4.13-v2 branch. Will resubmit v2 (tomorrow or later) once after gathering reviews. thanks, Takashi
