Re: [PATCH 1/2] nfit: Use init_completion() in acpi_nfit_flush_probe()

[Thomas Gleixner]

On Wed, 23 Aug 2017, Boqun Feng wrote:

> There is no need to use COMPLETION_INITIALIZER_ONSTACK() in
> acpi_nfit_flush_probe(), replace it with init_completion().

You completely fail to explain WHY.

Thanks,

        tglx

 
> Signed-off-by: Boqun Feng <boqun.f...@gmail.com>
> ---
>  drivers/acpi/nfit/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> index 19182d091587..1893e416e7c0 100644
> --- a/drivers/acpi/nfit/core.c
> +++ b/drivers/acpi/nfit/core.c
> @@ -2884,7 +2884,7 @@ static int acpi_nfit_flush_probe(struct 
> nvdimm_bus_descriptor *nd_desc)
>        * need to be interruptible while waiting.
>        */
>       INIT_WORK_ONSTACK(&flush.work, flush_probe);
> -     COMPLETION_INITIALIZER_ONSTACK(flush.cmp);
> +     init_completion(&flush.cmp);
>       queue_work(nfit_wq, &flush.work);
>       mutex_unlock(&acpi_desc->init_mutex);
>  
> -- 
> 2.14.1
> 
>