On Mon, 2017-08-28 at 10:53 -0600, Tyler Baicar wrote:
> Currently we acknowledge errors before clearing the error status.
> This could cause a new error to be populated by firmware in-between
> the error acknowledgment and the error status clearing which would
> cause the second error's status to be cleared without being handled.
> So, clear the error status before acknowledging the errors.
>
> Also, make sure to acknowledge the error if the error status read
> fails.
>
> +out:
> + ghes_clear_estatus(ghes);
> +
> + if (rc == -ENOENT)
> + return rc;
> +
> /*
> * GHESv2 type HEST entries introduce support for error
> acknowledgment,
> * so only acknowledge the error if this support is present.
> */
>
> + if (is_hest_type_generic_v2(ghes))
You can also do this here, like
if (is_hest_type_generic_v2(ghes) && rc != -ENOENT)
though I left this for Rafael to choose which one is preferable.
> + return ghes_ack_error(ghes->generic_v2);
> +
--
Andy Shevchenko <andriy.shevche...@linux.intel.com>
Intel Finland Oy
