>-----Original Message----- >From: Mark Brown [mailto:broo...@kernel.org] >Sent: Thursday, August 31, 2017 4:54 AM >To: Ryan Lee <ryans....@maximintegrated.com> >Cc: lgirdw...@gmail.com; pe...@perex.cz; ti...@suse.com; >kuninori.morimoto...@renesas.com; alsa-de...@alsa-project.org; linux- >ker...@vger.kernel.org; ryan.lee.ma...@gmail.com >Subject: Re: [PATCH 5/9] ASoC: max98927: Removed obsolete variables > >On Mon, Aug 28, 2017 at 04:30:57PM -0700, Ryan Lee wrote: >> Signed-off-by: Ryan Lee <ryans....@maximintegrated.com> > >Why are these variables obsolete? If their use was removed in earlier patches >in >the series they should be handled in that patch, if they're just unused say >so. In >general your changelogs could really benefit from being a bit longer and >explaining why changes are being made. > >> mode change 100644 => 100755 sound/soc/codecs/max98927.h > >This also changes the permissions to be executable which isn't what we want.
Thank you for your comment. I wanted to remove these variables because it have never been referred in max98927.c from the beginning.
