On Mon 11-09-17 21:43:23, Christophe JAILLET wrote: > If the 'kmalloc' fails, we must go through the existing error handling > path. > > Signed-off-by: Christophe JAILLET <[email protected]>
Looks good to me. You can add: Reviewed-by: Jan Kara <[email protected]> Honza > --- > mm/backing-dev.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/mm/backing-dev.c b/mm/backing-dev.c > index f028a9a472fd..e19606bb41a0 100644 > --- a/mm/backing-dev.c > +++ b/mm/backing-dev.c > @@ -569,8 +569,10 @@ static int cgwb_create(struct backing_dev_info *bdi, > > /* need to create a new one */ > wb = kmalloc(sizeof(*wb), gfp); > - if (!wb) > - return -ENOMEM; > + if (!wb) { > + ret = -ENOMEM; > + goto out_put; > + } > > ret = wb_init(wb, bdi, blkcg_css->id, gfp); > if (ret) > -- > 2.11.0 > -- Jan Kara <[email protected]> SUSE Labs, CR
