On Tue, 2017-09-12 at 17:09 +0300, Dan Carpenter wrote: > On Tue, Sep 12, 2017 at 03:02:04PM +0100, Emil Velikov wrote: > > That said, I'm not sure how useful the information is - perhaps > > it's > > better to drop it all together? > > Or a WARN_ONCE().
It's userspace calling into the driver with invalid parameters. IMO we should never WARN_ONCE() on something userspace can trigger. I'd suggest to just drop the message altogether, simply throwing EINVAL at userspace is perfectly fine IMHO. cheers, Gerd
