On Fri, 27 Apr 2007 19:50:19 -0700 Roland Dreier <[EMAIL PROTECTED]> wrote:
> The changelog says: > > fs/sysfs/bin.c: In function 'read': > fs/sysfs/bin.c:77: warning: format '%zd' expects type 'signed size_t', > but argument 4 has type 'int' > > but the signature of the function read() is > > read(struct file * file, char __user * userbuf, size_t count, loff_t * > off) > > and git blame seems to show it was always thus -- ie count was always size_t. > > And now on x86-64 and ia64 with gcc 4.1 at least, I get: > > fs/sysfs/bin.c: In function 'read': > fs/sysfs/bin.c:62: warning: format '%d' expects type 'int', but argument > 4 has type 'size_t' Some patches landed out of order. In Greg's tree (with Tejun's patches) `count' is a local variable (not an incoming arg) of type `int'. So this patch was against Tejun's stuff, not against mainline. I'd have picked that up, but I went and assumed that it was a victim of the new dev_dbg() printk arg checking stuff. Ho hum. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
