On Sat, Apr 28, 2007 at 07:50:39AM -0700, William Lee Irwin III wrote: > On Sat, Apr 28, 2007 at 04:19:23PM +0900, Akinobu Mita wrote: > > init_hugetlbfs_fs() needs to unregister hugetlbfs > > when kern_mount() returns error. > > Cc: William Irwin <[EMAIL PROTECTED]> > > Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]> > > This patch resolves a clear failure to error check.
I reconsider this patch. It was wrong. Because it is overkill to unregister filesystem just for hugetlbfs_vfsmount mount failure. Because hugetlbfs_vfsmount is only used for shumget() system call and also there is some race condition between register_filesystem() and unregister_filesystem(). (it's not likely happen though) So what we can do for hugetlbfs module_init failure is adding NULL check for hugetlbfs_vfsmount in hugetlb_zero_setup(). - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
