Since GCC version 3.1, it is possible to specify input and output operands using symbolic names which can be referenced within the assembler code.
Convert to named operands makes easy to understand and maintain for future changes. Signed-off-by: Miguel Bernal Marin <[email protected]> --- arch/x86/include/asm/rwsem.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/include/asm/rwsem.h b/arch/x86/include/asm/rwsem.h index 2b3fb6d316f5..3245902e961f 100644 --- a/arch/x86/include/asm/rwsem.h +++ b/arch/x86/include/asm/rwsem.h @@ -189,14 +189,14 @@ static inline void __up_write(struct rw_semaphore *sem) register void *__sp asm(_ASM_SP); asm volatile("# beginning __up_write\n\t" - LOCK_PREFIX " xadd %1,(%3)\n\t" + LOCK_PREFIX " xadd %[tmp],(%[sem])\n\t" /* subtracts 0xffff0001, returns the old value */ " jns 1f\n\t" " call call_rwsem_wake\n" /* expects old value in %edx */ "1:\n\t" "# ending __up_write\n" - : "+m" (sem->count), "=d" (tmp), "+r" (__sp) - : "a" (sem), "1" (-RWSEM_ACTIVE_WRITE_BIAS) + : "+m" (sem->count), [tmp] "=d" (tmp), "+r" (__sp) + : [sem] "a" (sem), "[tmp]" (-RWSEM_ACTIVE_WRITE_BIAS) : "memory", "cc"); } -- 2.14.1
