kasprintf() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
        Calling coda_free_framebuffers to release already allocated buffers.

 drivers/media/platform/coda/coda-bit.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/media/platform/coda/coda-bit.c 
b/drivers/media/platform/coda/coda-bit.c
index 291c409..bfc4ecf 100644
--- a/drivers/media/platform/coda/coda-bit.c
+++ b/drivers/media/platform/coda/coda-bit.c
@@ -417,6 +417,10 @@ static int coda_alloc_framebuffers(struct coda_ctx *ctx,
                    dev->devtype->product != CODA_DX6)
                        size += ysize / 4;
                name = kasprintf(GFP_KERNEL, "fb%d", i);
+               if (!name) {
+                       coda_free_framebuffers(ctx);
+                       return -ENOMEM;
+               }
                ret = coda_alloc_context_buf(ctx, &ctx->internal_frames[i],
                                             size, name);
                kfree(name);
-- 
1.9.1

Reply via email to