Hi Viresh, On 2017년 09월 21일 05:25, Viresh Kumar wrote: > The notifier callbacks may want to call some OPP helper routines which > may try to take the same opp_table->lock again and cause a deadlock. One > such usecase was reported by Chanwoo Choi, where calling > dev_pm_opp_disable() leads us to the devfreq's OPP notifier handler, > which further calls dev_pm_opp_find_freq_floor() and it deadlocks. > > We don't really need the opp_table->lock to be held across the notifier > call though, all we want to make sure is that the 'opp' doesn't get > freed while being used from within the notifier chain. We can do it with > help of dev_pm_opp_get/put() as well. Let's do it. > > Reported-by: Chanwoo Choi <[email protected]> > Reviewed-by: Stephen Boyd <[email protected]> > Signed-off-by: Viresh Kumar <[email protected]> > --- > V1->V2: > - s/Lets/Let's/ in commit log and added Stephen's tag. >
Thanks for your fixup. Looks good to me. IMHO, this patch should be posted to [email protected]. Tested-by: Chanwoo Choi <[email protected]> Reviewed-by: Chanwoo Choi <[email protected]> [snip] -- Best Regards, Chanwoo Choi Samsung Electronics
