On Wed, Sep 20, 2017 at 12:55:07PM +0530, Arvind Yadav wrote: > kasprintf() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> > --- > drivers/gpu/drm/tegra/dc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c > index 4df3911..f3214a1 100644 > --- a/drivers/gpu/drm/tegra/dc.c > +++ b/drivers/gpu/drm/tegra/dc.c > @@ -1695,6 +1695,8 @@ static int tegra_dc_debugfs_init(struct tegra_dc *dc, > struct drm_minor *minor) > int err; > > name = kasprintf(GFP_KERNEL, "dc.%d", dc->pipe); > + if (!name) > + return -ENOMEM; > dc->debugfs = debugfs_create_dir(name, minor->debugfs_root);
Indeed, doesn't look like debugfs_create_dir() can be safely called w/ name==NULL. Reviewed-by: Ville Syrjälä <ville.syrj...@linux.intel.com> > kfree(name); > > -- > 1.9.1 > > _______________________________________________ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Ville Syrjälä Intel OTC
