On Thu, Sep 21, 2017 at 05:07:06PM +0200, SF Markus Elfring wrote: > @@ -1913,11 +1908,12 @@ static int usbvision_set_compress_params(struct > usb_usbvision *usbvision) > USB_DIR_OUT | USB_TYPE_VENDOR | > USB_RECIP_ENDPOINT, 0, > (__u16) USBVISION_PCM_THR1, value, 6, HZ); > + if (rc < 0) > +report_failure: > + dev_err(&usbvision->dev->dev, > + "%s: ERROR=%d. USBVISION stopped - reconnect or reload > driver.\n", > + __func__, rc);
You've been asked several times not to write code like this. You do it later in the patch series as well. regards, dan carpenter
