On 09/21/2017 08:59 AM, Christoph Hellwig wrote: > On Wed, Sep 20, 2017 at 09:32:59AM -0600, Jens Axboe wrote: >> Laptop mode really wants to writeback the number of dirty >> pages and inodes. Instead of calculating this in the caller, >> just pass in 0 and let wakeup_flusher_threads() handle it. >> >> Use the new wakeup_flusher_threads_bdi() instead of rolling >> our own. This changes the writeback to not be range cyclic, >> but that should not matter for laptop mode flush-all >> semantics. > > Looks good, > > Reviewed-by: Christoph Hellwig <h...@lst.de> > > While we're at sorting out the laptop_mode_wb_timer mess: > can we move initializing and deleting it from the block code > to the backing-dev code given that it now doesn't assume anything > about block devices any more?
Good point, I'll include that in a followup for 4.15. -- Jens Axboe
