On Tue, Sep 26, 2017 at 09:03:50PM +0300, Alexander Kochetkov wrote: > Hello Vinod! Thanks for review! > > > 26 сент. 2017 г., в 20:37, Vinod Koul <[email protected]> написал(а): > > > > Tested-by please... > > In order to test the patch the driver should be rebuild with NR_DEFAULT_DESC > defined to 1 > and with some trace code included. Is it OK if I provide second patch I used > for testing > with trace showing how change work? > > > one more wrapper why, we dont have any logic here! > The idea was to keep rest of driver code intact. Ok, I’ll send v2 with no > wrappers. > > > right justifed please > > > Some functions has two tabs on second line, some has alignment to beginning of > argument declaration. How correct? > > 1) or like this (two tabs) > static int add_desc(struct list_head *pool, spinlock_t *lock, > gfp_t flg, int count) > > 2) Like this: > static int add_desc(struct list_head *pool, spinlock_t *lock, > gfp_t flg, int count)
Second one with one more tab :) See Section 2 Breaking long lines and strings in Documentation/process/coding-style.rst -- ~Vinod
