On Tue 2017-09-26 15:25:10, Sergey Senozhatsky wrote: > Do not strdup() console options. It seems that the only reason for > it to be strdup()-ed was a compilation warning: printk, UART and > console drivers, for some reason, expect char pointer instead of > const char pointer. So we can just pass `of_stdout_options', but > need to cast it to char pointer. A better fix would be to change > printk, console drivers and UART to accept const char `options'; > but that will take time - there are lots of drivers to update. > > The patch also fixes a possible memory leak: add_preferred_console() > can fail, but we don't kfree() options. > > Signed-off-by: Sergey Senozhatsky <sergey.senozhat...@gmail.com>
Of course, it would be better to change add_preferred_console(). But it would trigger many other changes. This alternative "temporary" change looks safe to me. Feel free to use Reviewed-by: Petr Mladek <pmla...@suse.com> Best Regards, Petr
