On Mon, Oct 2, 2017 at 2:08 PM, Quentin Schulz <quentin.sch...@free-electrons.com> wrote:
> On AXP813/818, GPIO0 and GPIO1 can be used as LDO as (respectively) > ldo_io0 and ldo_io1. (...) > + gpio0_ldo: gpio0_ldo { > + pins = "GPIO0"; > + function = "ldo"; > + }; (...) > + pinctrl-names = "default"; > + pinctrl-0 = <&gpio0_ldo>; > /* Disable by default to avoid conflicts with GPIO */ > status = "disabled"; So this is still by default disabled, but you make the default mode something called "ldo". And I think that is to be understood as a low-dropout regulator? So is the idea that this should be represented as a regulator in the end? Then I think the state name should not be "default" rather something like "regulator" and "default" should be the GPIO mode, as I guess something like that exists. Activating a regulator using pin control "default" mode is not very pretty. It would probably be unintuitive and end up wasting power because people will get confused about what is going on. Instead, call this state "regulator" and when using, in Linux create a regulator device that set the pin into "regulator" state to start using it as a LDO, and "default" to deactivate it as LDO, if that is how the usage is intended. Yours, Linus Walleij