On Thu, 5 Oct 2017, Joe Perches wrote:
> On Thu, 2017-10-05 at 21:13 +0200, Julia Lawall wrote: > > > > On Fri, 6 Oct 2017, Masahiro Yamada wrote: > > > > > 2017-10-01 21:42 GMT+09:00 Julia Lawall <julia.law...@lip6.fr>: > > > > This semantic patch detects duplicate arrays declared using BQ27XXX_DATA > > > > within a single structure. It is currently specific to the file > > > > drivers/power/supply/bq27xxx_battery.c. > > > > > > > > Signed-off-by: Julia Lawall <julia.law...@lip6.fr> > > > > > > > > --- > > > > > > Applied to linux-kbuild/misc. > > > > Thanks for picking it up. > > If it is specific to one file, why not just run it > and post the resultant patch? Why have it in tree? I guess that they anticipate that the data may change in the future? If id-utils is used, Coccinelle will completely ignore files that don't contain BQ27XXX_DATA, so the rule will have essentially no performance impact. If there is no indexing, it will only "grep" for BQ27XXX_DATA, not actually parse the files that don't contain it. So there is not much performance impact even in that case. julia
