On Mon, Apr 30, 2007 at 05:08:59PM -0500, Corey Minyard wrote: > I think I've spotted a bug in the 8250 code, but I'm not really > sure.
Yes, clearing lsr_break_flag prior to opening the port is probably a good thing. > I'm having a hard time understanding why the lsr_break_flag > is necessary. Merely reading the LSR clears status bits. We read the LSR repeatedly so that we can monitor the transmit FIFO when outputting serial console messages. This means that if you have a busy serial console, and you want to send it a sysrq request, there's a chance that the break flag in the LSR will be cleared by the transmit FIFO status polling code thereby being lost. So, we need to remember that status, and we do this via the lsr_break_flag. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
