On 10/10/2017 05:39 PM, Dave Hansen wrote: > On 10/10/2017 07:57 AM, Michal Hocko wrote: >>> But, let's be honest, this leaves us with an option that nobody is ever >>> going to turn on. IOW, nobody except a very small portion of our users >>> will ever see any benefit from this. >> But aren't those small groups who would like to squeeze every single >> cycle out from the page allocator path the targeted audience? > > They're the reason we started looking at this. They also care the most. > > But, the cost of these stats, especially we get more and more cores in a > NUMA node is really making them show up in profiles. It would be nice > to get rid of them there, too.
Furthermore, the group that actually looks at those stats, could be also expected to be quite small. The group that cares neither about the stats, nor relies on top allocator performance, might still arguably benefit from improved allocator performance, but won't for sure benefit from the stats. > Aaron, do you remember offhand how much of the allocator overhead was > coming from NUMA stats? >