On 10/10/17 22:42, Jacob Pan wrote: [...] >>> +/** >>> + * PASID table data used to bind guest PASID table to the host >>> IOMMU. This will >>> + * enable guest managed first level page tables. >>> + * @version: for future extensions and identification of the data >>> format >>> + * @bytes: size of this structure >>> + * @base_ptr: PASID table pointer >>> + * @pasid_bits: number of bits supported in the guest PASID >>> table, must be less >>> + * or equal than the host table size. >> >> "host table size" is a bit confusing in this context, especially if >> using multi-level tables. Perhaps it's clear enough that @pasid_bits >> must be smaller or equal than the PASID size supported by the IOMMU, >> and we can remove that second part? >> > Not sure what is the second part?
"must be less or equal than the host table size", is confusing to me when you're talking about max PASID bits Thanks, Jean