On Fri, Oct 13, 2017 at 6:08 PM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > On Fri, 13 Oct 2017, Bhumika Goyal wrote: > >> These structures are passed to the eeh_ops_register function during the >> initialization phase. There they get stored in a structure variable >> which only makes function calls through function pointers. There is no >> other usage of these eeh_ops structures and their fields are never >> modified after init phase. So, make them __ro_after_init. > > I think they could be const. >
Yes. I will send a patch for const. > julia > >> Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> >> --- >> arch/powerpc/platforms/powernv/eeh-powernv.c | 2 +- >> arch/powerpc/platforms/pseries/eeh_pseries.c | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/powerpc/platforms/powernv/eeh-powernv.c >> b/arch/powerpc/platforms/powernv/eeh-powernv.c >> index 4650fb2..d2a53df 100644 >> --- a/arch/powerpc/platforms/powernv/eeh-powernv.c >> +++ b/arch/powerpc/platforms/powernv/eeh-powernv.c >> @@ -1731,7 +1731,7 @@ static int pnv_eeh_restore_config(struct pci_dn *pdn) >> return 0; >> } >> >> -static struct eeh_ops pnv_eeh_ops = { >> +static struct eeh_ops pnv_eeh_ops __ro_after_init = { >> .name = "powernv", >> .init = pnv_eeh_init, >> .probe = pnv_eeh_probe, >> diff --git a/arch/powerpc/platforms/pseries/eeh_pseries.c >> b/arch/powerpc/platforms/pseries/eeh_pseries.c >> index 6b812ad..6fedfc9 100644 >> --- a/arch/powerpc/platforms/pseries/eeh_pseries.c >> +++ b/arch/powerpc/platforms/pseries/eeh_pseries.c >> @@ -684,7 +684,7 @@ static int pseries_eeh_write_config(struct pci_dn *pdn, >> int where, int size, u32 >> return rtas_write_config(pdn, where, size, val); >> } >> >> -static struct eeh_ops pseries_eeh_ops = { >> +static struct eeh_ops pseries_eeh_ops __ro_after_init = { >> .name = "pseries", >> .init = pseries_eeh_init, >> .probe = pseries_eeh_probe, >> -- >> 1.9.1 >> >>