On Sun, Oct 15, 2017 at 05:02:03PM +0100, Colin King wrote: > From: Colin Ian King <[email protected]> > > The variable this_leaf is being assigned a value that is never > read and it is being updated a little later with a newer value, > hence we can remove the redundant assignment. > > Cleans up clang warning: Value stored to 'this_leaf' is never read > > Signed-off-by: Colin Ian King <[email protected]> > --- > arch/x86/kernel/cpu/intel_cacheinfo.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/x86/kernel/cpu/intel_cacheinfo.c > b/arch/x86/kernel/cpu/intel_cacheinfo.c > index 24f749324c0f..9990a71e311f 100644 > --- a/arch/x86/kernel/cpu/intel_cacheinfo.c > +++ b/arch/x86/kernel/cpu/intel_cacheinfo.c > @@ -831,7 +831,6 @@ static int __cache_amd_cpumap_setup(unsigned int cpu, int > index, > } else if (boot_cpu_has(X86_FEATURE_TOPOEXT)) { > unsigned int apicid, nshared, first, last; > > - this_leaf = this_cpu_ci->info_list + index; > nshared = base->eax.split.num_threads_sharing + 1; > apicid = cpu_data(cpu).apicid; > first = apicid - (apicid % nshared); > --
Looks ok to me. Reviewed-by: Borislav Petkov <[email protected]> -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.
