From: woojung....@microchip.com > Sent: 13 October 2017 18:59 > > >> > + REG_WRITE(REG_GLOBAL, GLOBAL_MAC_01, (addr[0] << 9) | > > >> addr[1]); > > >> > > >> Is that supposed to be 9 ? > > > > > > Looks like it. > > > Check > > http://www.marvell.com/switching/assets/marvell_linkstreet_88E6060_data > > sheet.pdf > > > > Hum, David is correct, there is a bug in the driver which needs to be > > addressed first. MAC address bit 40 is addr[0] & 0x1, thus we must > > shift byte 0 by 8 and mask it against 0xfe. > > > > I'll respin this serie including a fix for both net and net-next. > > Yes, you are right. Missed description about bit 40.
Since they are all random numbers it doesn't matter. Actually isn't this just masking off the non-unicast bit? So it won't be set in the data - and so doesn't need masking. David