Eric Biggers <ebigge...@gmail.com> wrote: > > - if (test_bit(KEY_FLAG_INSTANTIATED, &key->flags)) > > + if (state == KEY_IS_INSTANTIATED) > > atomic_dec(&key->user->nikeys); > > This changes the behavior. Previously ->nikeys counted both negatively and > positively instantiated keys, while this change implies that it now will only > count positively instantiated keys. I think you meant 'state != > KEY_IS_UNINSTANTIATED'? Renaming KEY_IS_INSTANTIATED to KEY_IS_POSITIVE or > KEY_IS_POSITIVELY_INSTANTIATED also might help reduce this confusion.
Yeah - I think I'm confusing myself by overloading 'instantiated' in my mind. David
