On Tue, Oct 17, 2017 at 04:18:18PM +0800, Huang, Ying wrote: > From: Huang Ying <ying.hu...@intel.com> > > Now, when the page table is walked in the implementation of > /proc/<pid>/pagemap, pmd_soft_dirty() is used for both the PMD huge > page map and the PMD migration entries. That is wrong, > pmd_swp_soft_dirty() should be used for the PMD migration entries > instead because the different page table entry flag is used. > > Cc: Michal Hocko <mho...@suse.com> > Cc: "Kirill A. Shutemov" <kirill.shute...@linux.intel.com> > Cc: David Rientjes <rient...@google.com> > Cc: Arnd Bergmann <a...@arndb.de> > Cc: Hugh Dickins <hu...@google.com> > Cc: "Jérôme Glisse" <jgli...@redhat.com> > Cc: Daniel Colascione <dan...@google.com> > Cc: Zi Yan <zi....@cs.rutgers.edu> > Cc: Naoya Horiguchi <n-horigu...@ah.jp.nec.com> > Signed-off-by: "Huang, Ying" <ying.hu...@intel.com>
What is effect of the misbehaviour? pagemap reports garbage? Shoudn't it be in stable@? And maybe add Fixes: <sha1>. Otherwise, looks good to me. Acked-by: Kirill A. Shutemov <kirill.shute...@linux.intel.com> -- Kirill A. Shutemov