On 10/19/2017 09:59 AM, Christoph Hellwig wrote: > On Mon, Oct 16, 2017 at 06:43:26PM -0500, Bjorn Helgaas wrote: >> understand it. I guess the idea is to build pcie-artpec6.o if either >> CONFIG_PCIE_ARTPEC6_HOST or CONFIG_PCIE_ARTPEC6_EP is set (or both). >> >> Is this really the simplest way to express that in Kconfig? Both the >> "if PCIE_ARTPEC6" and this ifneq thing are complicated and relatively >> unusual. > > I thijnk the right style is to make PCIE_ARTPEC6 a hidden kconfig > symbol without help text, and then have PCIE_ARTPEC6_HOST and > PCIE_ARTPEC6_EP select it. >
Thanks for the suggestion Christoph! I will make this change for both pci-dra7xx and pcie-artpec6 in the next version of the patch series, and then Kishon can ACK/NACK.
