> -----Original Message----- > From: Greg KH [mailto:g...@kroah.com] > Sent: Friday, October 20, 2017 8:24 AM > To: Limonciello, Mario <mario_limoncie...@dell.com> > Cc: dvh...@infradead.org; Andy Shevchenko <andy.shevche...@gmail.com>; > LKML <linux-kernel@vger.kernel.org>; platform-driver-...@vger.kernel.org; Andy > Lutomirski <l...@kernel.org>; quasi...@google.com; pali.ro...@gmail.com; > r...@rjwysocki.net; mj...@google.com; h...@lst.de; Alan Cox > <gno...@lxorguk.ukuu.org.uk> > Subject: Re: [PATCH v10 13/15] platform/x86: wmi: create userspace interface > for > drivers > > On Thu, Oct 19, 2017 at 12:50:16PM -0500, Mario Limonciello wrote: > > +#ifdef CONFIG_COMPAT > > + .compat_ioctl = wmi_ioctl, > > Why do you still need a compat ioctl?
Being able to run 32 bit app on 64 bit kernel. Removing the .compat_ioctl definition and they fail. So do you mean specifically the #ifdef CONFIG_COMPAT? I do see that compat_ioctl is declared without it in linux/fs.h, but I'll admit I'm unsure what happens if the kernel is compiled without CONFIG_COMPAT and you try to run 32 bit apps. _Should_ that work?
