On Fri, Oct 20, 2017 at 09:55:40AM +0200, Borislav Petkov wrote: > On Wed, Oct 18, 2017 at 11:30:54PM -0700, Ricardo Neri wrote: > > I saw that Documentation/process/email-clients.rst that emailed patches > > should be in ASCII or UTF-8 encodings only, but my patch in UTF-8 > > causes problems. Then is UTF-8 not desirable? > > Well, I don't think so even though I couldn't find anything that says so > explicitly. > > But I *think* source files' encoding should be ASCII, as otherwise even > the tool patch barfs: > > patch: **** malformed patch at line 124:
I will stay away from UTF-8. > > > Thanks for the detailed explanation and the pointers to fix the problem. > > I am sorry for the inconvenience. Here is the patch again. I made sure > > that it applies cleanly with git am and patch: > > Yes, it looks good now: > > Reviewed-by: Borislav Petkov <b...@suse.de> Thank you! > > ( ... or I've been staring definitely too long at this code and don't care > anymore :-))) Your guidance definitely helped to make it more readable. BR, Ricardo
