Re: [PATCH v2 3/3] watchdog: hpwdt: add ioctl WDIOC_GETPRETIMEOUT

[Guenter Roeck]

On 10/23/2017 03:46 PM, Jerry Hoemann wrote:

Add support for WDIOC_GETPRETIMEOUT ioctl so that user applications
can determine when the NMI should arrive.

Signed-off-by: Jerry Hoemann <jerry.hoem...@hpe.com>

I'll leave this for Wim to decide. My take is that we should not add 
functionality
to old-style drivers and convert those drivers to use the watchdog core instead.

Thanks,
Guenter

---
  drivers/watchdog/hpwdt.c | 7 +++++++
  1 file changed, 7 insertions(+)

diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
index e616583..b64ce43 100644
--- a/drivers/watchdog/hpwdt.c
+++ b/drivers/watchdog/hpwdt.c
@@ -50,6 +50,7 @@
  static bool nowayout = WATCHDOG_NOWAYOUT;
  static char expect_release;
  static unsigned long hpwdt_is_open;
+static const int pretimeout = 9;

static void __iomem *pci_mem_addr; /* the PCI-memory address */

  static unsigned long __iomem *hpwdt_nmistat;
@@ -631,6 +632,12 @@ static long hpwdt_ioctl(struct file *file, unsigned int 
cmd,
                }
                break;

+ case WDIOC_GETPRETIMEOUT:

+               ret = copy_to_user(argp, &pretimeout, sizeof(pretimeout));
+               if (ret)
+                       ret = -EFAULT;
+               break;
+
        case WDIOC_SETTIMEOUT:
                ret = get_user(new_margin, p);
                if (ret)