On Thu, Oct 26, 2017 at 12:59:08AM +0200, Jason A. Donenfeld wrote: > On Thu, Oct 26, 2017 at 12:27 AM, Tobin C. Harding <[email protected]> wrote: > > How good is unlikely()? > > It places that branch way at the bottom of the function so that it's > less likely to pollute the icache.
But always measure it. Lots of times (old numbers were 90% or so), we get the marking wrong, so please, always benchmark the thing to verify it actually is doing what you think it should be doing, otherwise it could make the code worse. thanks, greg k-h
