> -----Original Message----- > From: Hal Rosenstock [mailto:[email protected]] > Sent: Friday, October 27, 2017 3:19 PM > To: Parav Pandit <[email protected]>; Thomas Bogendoerfer > <[email protected]>; Matan Barak <[email protected]>; Leon > Romanovsky <[email protected]>; Doug Ledford <[email protected]>; > [email protected]; [email protected] > Cc: Ghazale Hosseinabadi <[email protected]> > Subject: Re: [PATCH] IB/mlx5: give back valid speed/width even without plugged > in SFP module > > On 10/27/2017 2:32 PM, Parav Pandit wrote: > > However I believe that ibstat tool should be enhanced to report unknown port > speed instead of expecting drivers to supply some random number like this. > > ibstat gets the rate from libibumad via /sys/class/infiniband/<IB > device>/ports/<port number>/rate file which is supposed to be populated by the > driver. Is there no rate file in this error case ? > <...>/<port_num>/rate file exist.
rate_show() has invalid active_width as expected due to nonexistence of SFP. So sysfs call return invalid value. We don't have invalid_active_width defined right now. So ibstat and other applications should not crash on such valid errors.
