On Sun, 29 Oct 2017 13:14:26 +0000 Colin King <[email protected]> wrote:
> From: Colin Ian King <[email protected]> > > The pointer p is being initialized with one value and a few lines > later being set to a newer replacement value. Clean up the code by > using the latter assignment to p as the initial value. Cleans up > clang warning: > > drivers/mtd/ubi/fastmap.c:217:19: warning: Value stored to 'p' > during its initialization is never read > > Signed-off-by: Colin Ian King <[email protected]> Reviewed-by: Boris Brezillon <[email protected]> > --- > drivers/mtd/ubi/fastmap.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c > index 5a832bc79b1b..9be4b94e83ad 100644 > --- a/drivers/mtd/ubi/fastmap.c > +++ b/drivers/mtd/ubi/fastmap.c > @@ -214,9 +214,8 @@ static void assign_aeb_to_av(struct ubi_attach_info *ai, > struct ubi_ainf_volume *av) > { > struct ubi_ainf_peb *tmp_aeb; > - struct rb_node **p = &ai->volumes.rb_node, *parent = NULL; > + struct rb_node **p = &av->root.rb_node, *parent = NULL; > > - p = &av->root.rb_node; > while (*p) { > parent = *p; >
