Hi Markus, On Mon, Oct 30, 2017 at 7:11 AM, SF Markus Elfring <elfr...@users.sourceforge.net> wrote: > From: Markus Elfring <elfr...@users.sourceforge.net> > Date: Sun, 29 Oct 2017 18:38:04 +0100 > > Add a jump target so that a bit of exception handling can be better reused > at the end of this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> > --- > drivers/net/wireless/ti/wlcore/main.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/wireless/ti/wlcore/main.c > b/drivers/net/wireless/ti/wlcore/main.c > index c346c021b999..48380d48ef09 100644 > --- a/drivers/net/wireless/ti/wlcore/main.c > +++ b/drivers/net/wireless/ti/wlcore/main.c > @@ -6551,6 +6549,11 @@ static void wlcore_nvs_cb(const struct firmware *fw, > void *context) > out: > release_firmware(fw); > complete_all(&wl->nvs_loading_complete); > + return; > + > +power_off:
Name this "out_power_off" to match the other labels. > + wl1271_power_off(wl); > + goto out_free_nvs; Why not put this in front of the out_free_nvs label? It looks weird here. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/
