On Wed, May 02, 2007 at 05:11:45PM -0400, Kristian H??gsberg wrote: > The firewire-cdev.h file is meant to be a self-contained userspace header > file and shouldn't include other kernel header files. All duplicated > values are standardized ieee1394 values and won't ever change. I should > put a #ifndef __FW_COMMON_DEFINES protection around the duplicate values, I > guess, but I'm just wondering why I never saw a "symbol redefined" > warning...
No, defining things in two places is not okay. Just add a new header that defines these protocol constants, which needs to be included by userspace that wants to use them. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/