Em Thu, Nov 02, 2017 at 01:16:32PM +0100, Jiri Olsa escreveu: > On Wed, Oct 11, 2017 at 05:01:23PM +0200, Jiri Olsa wrote: > > hi, > > I'm working on script profiling support and came up > > with some generic annotation code changes, which IMO > > make the code simpler and more generic. > > > > The main idea of this patchset is to have generic > > struct (annotation_line), which holds the common > > profile data. Having this we can easily add new > > types, like script annotation support. Currently > > there's disasm_line support only. > > > > It's also available at: > > git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git perf/annotate > > updated with last perf/core and pushed out
Can you please ellaborate, write _why_ you're doing these things instead of just saying _what_ is being done? Author: Jiri Olsa <[email protected]> Date: Thu Sep 28 23:13:38 2017 +0200 perf annotate browser: Change selection to struct annotation_line Use struct annotation_line as a browser::selection. Link: http://lkml.kernel.org/n/[email protected] Signed-off-by: Jiri Olsa <[email protected]> commit 902e9181b8f3807a4e51b587c3e5dcd32d61d3b2 Author: Jiri Olsa <[email protected]> Date: Tue Oct 3 15:51:43 2017 +0200 perf annotate browser: Rename disasm_line__browser to browser_line Renaming disasm_line__browser function to browser_line. Link: http://lkml.kernel.org/n/[email protected] Signed-off-by: Jiri Olsa <[email protected]> commit f75c5dcbb250af16621cf0d4d42efa2ba08641cf Author: Jiri Olsa <[email protected]> Date: Tue Oct 3 15:48:39 2017 +0200 perf annotate browser: Rename struct browser_disasm_line to browser_line Renaming struct browser_disasm_line to browser_line. Link: http://lkml.kernel.org/n/[email protected] Signed-off-by: Jiri Olsa <[email protected]>
