Re: [PATCH v8 2/5] irqchip/irq-goldfish-pic: Add Goldfish PIC driver

[Joe Perches]

On Fri, 2017-11-03 at 18:21 +0100, Aleksandar Markovic wrote:
> From: Miodrag Dinic <miodrag.di...@mips.com>
[]
> diff --git a/drivers/irqchip/irq-goldfish-pic.c 
> b/drivers/irqchip/irq-goldfish-pic.c
[]
> +static int __init goldfish_pic_of_init(struct device_node *of_node,
> +                                    struct device_node *parent)
> +{
[]
> +     parent_irq = irq_of_parse_and_map(of_node, 0);
> +     if (!parent_irq) {
> +             pr_err("Failed to map parent IRQ!");

All the pr_<foo> uses should end with a newline

                pr_err("Failed to map parent IRQ\n");

etc...

> +     gc = irq_alloc_generic_chip("GFPIC", 1, GFPIC_IRQ_BASE, gfpic->base,
> +                                 handle_level_irq);
> +     if (!gc) {
> +             pr_err("Failed to allocate chip structures!");
> +             ret = -ENOMEM;
> +             goto out_unmap_irq;
> +     }